GN-4810: get the roadsign-regulation plugin working with the rdfa-aware decision nodes
#418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested locally - works 🙏 |
dkozickis
approved these changes
Apr 29, 2024
abeforgit
merged commit 502b4c7
into
fix/rdfa-aware-decision-articles
0 of 3 checks passed
abeforgit
added a commit
that referenced
this pull request
Apr 29, 2024
* drop unnecessary backwards-compatible parse-rule for decision node * drop unnecessary backwards-compatible parse-rule for decision-title node * drop unnecessary backwards-compatible parse-rule for description node * drop unnecessary backwards-compatible parse-rule for motivering node * drop unnecessary backwards-compatible parse-rule for article-container node * drop unnecessary backwards-compatible parse-rule for decision-article node * drop unnecessary backwards-compatible parse-rule for decision-article-content node * linting * fix(decision-article): ensure that article number is positioned inline * make setStartNumber and getStartNumber properties optional * make numberConfig.convertNumber optional * rework rdfa-aware besluit_article node * adapt insert-structure command to support decision articles * GN-4810: get the `roadsign-regulation` plugin working with the `rdfa-aware` decision nodes (#418) --------- Co-authored-by: abeforgit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR includes some updates to the
roadsign-regulationplugin to ensure it works correctly in combination with therdfa-awaresystem.For now, I've decided to keep using the classic RDFa system for the roadsign regulations.
connected issues and PRs:
GN-4810
How to test/reproduce
Insert traffic measureinserts aroadsign_regulationnode correctly in a new article nodeChallenges/uncertainties
I have decided to hold off moving the
roadsign_regulationnode to the rdfa-aware system as I did not really yet see the point of moving these over.Checks PR readiness