Solve citation bug in chrome

CHANGELOG.md

@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Addition of list inputrules
 ### Fixed
 - Also observe responsive toolbar children for resize
+- Solve bug with cursor in front a multiple line link
 
 
 ### Changed

addon/plugins/chrome-hacks-plugin/index.ts

@@ -0,0 +1,38 @@
+import {
+  Decoration,
+  DecorationSet,
+  EditorState,
+  ProsePlugin,
+} from '@lblod/ember-rdfa-editor';
+import { chrome } from '@lblod/ember-rdfa-editor/utils/_private/browser';
+
+export function chromeHacksPlugin(): ProsePlugin {
+  const chromeHacksPlugin = new ProsePlugin({
+    props: {
+      decorations(state: EditorState): DecorationSet | undefined {
+        if (!chrome) {
+          return;
+        }
+        const { $from, from, to } = state.selection;
+        if (from !== to) {
+          return;
+        }
+        const nextNode = $from.nodeAfter;
+        if (nextNode?.type.spec.needsChromeCursorFix) {
+          return DecorationSet.create(state.doc, [
+            Decoration.widget(
+              from,
+              () => {
+                const fakeCursor = document.createElement('span');
+                return fakeCursor;
+              },
+              { side: 1 }
+            ),
+          ]);
+        }
+        return;
+      },
+    },
+  });
+  return chromeHacksPlugin;
+}

addon/plugins/link/nodes/link.ts

@@ -29,6 +29,7 @@ const emberNodeConfig: (options: LinkOptions) => EmberNodeConfig = (
       },
     },
     needsFFKludge: true,
+    needsChromeCursorFix: true,
     parseDOM: [
       {
         tag: 'a',

app/styles/ember-rdfa-editor.scss

@@ -37,7 +37,6 @@
   animation: ProseMirror-cursor-blink 1.1s steps(2, start) infinite;
 }
 
-
 @keyframes ProseMirror-cursor-blink {
   to {
     visibility: hidden;

tests/dummy/app/controllers/index.ts

@@ -63,6 +63,7 @@ import {
   ordered_list_input_rule,
 } from '@lblod/ember-rdfa-editor/plugins/list/input_rules';
 import { inputRules } from '@lblod/ember-rdfa-editor';
+import { chromeHacksPlugin } from '@lblod/ember-rdfa-editor/plugins/chrome-hacks-plugin';
 
 export default class IndexController extends Controller {
   @tracked rdfaEditor?: SayController;
@@ -117,6 +118,7 @@ export default class IndexController extends Controller {
   @tracked plugins: Plugin[] = [
     // disabled until https://binnenland.atlassian.net/browse/GN-4147 is fixed
     firefoxCursorFix(),
+    chromeHacksPlugin(),
     lastKeyPressedPlugin,
     tablePlugin,
     tableKeymap,

tests/dummy/app/controllers/plugins.ts

@@ -68,6 +68,8 @@ import {
   ordered_list_input_rule,
 } from '@lblod/ember-rdfa-editor/plugins/list/input_rules';
 import { inputRules } from '@lblod/ember-rdfa-editor';
+import { chromeHacksPlugin } from '@lblod/ember-rdfa-editor/plugins/chrome-hacks-plugin';
+import { firefoxCursorFix } from '@lblod/ember-rdfa-editor/plugins/firefox-cursor-fix';
 
 export default class IndexController extends Controller {
   @tracked rdfaEditor?: SayController;
@@ -132,6 +134,8 @@ export default class IndexController extends Controller {
     };
   };
   @tracked plugins: Plugin[] = [
+    firefoxCursorFix(),
+    chromeHacksPlugin(),
     highlightPlugin({ testKey: 'yeet' }),
     tablePlugin,
     tableKeymap,