allow creating custom form extensions #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVanHoof
reviewed
Jan 6, 2025
JonasVanHoof
reviewed
Jan 6, 2025
Rahien
force-pushed
the
karel/lmb-333-create-form-extensions
branch
from
e4117b1 to
3d9a0f5
Compare
JonasVanHoof
approved these changes
Jan 13, 2025
services/custom-forms.ts
Outdated
Comment on lines
108
to
319
| INSERT DATA { | ||
| ${sparqlEscapeUri(uri)} a form:Field; | ||
| ext:extendsGroup ${sparqlEscapeUri(fieldGroupUri)}; | ||
| sh:name ${sparqlEscapeString(name)}; | ||
| form:displayType ${sparqlEscapeUri(fieldDescription.displayType)}; | ||
| sh:order ${sparqlEscapeInt(fieldDescription.order || 99999)}; | ||
| sh:path ${sparqlEscapeUri(fieldDescription.path || generatedPath)}; | ||
| mu:uuid ${sparqlEscapeString(id)}. | ||
| ${sparqlEscapeUri(formUri)} form:includes ${sparqlEscapeUri(uri)}. | ||
| } |
There was a problem hiding this comment.
if we add validateBy here could we than pass on form validations? :D
… error about unused variable or not existing pops up
Rahien
force-pushed
the
karel/lmb-333-create-form-extensions
branch
from
6a65bd0 to
3799065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows the creation of custom form extensions by adding fields to forms and removing fields that have been added in this way (only from custom forms)
How to test
see lblod/frontend-lokaal-mandatenbeheer#449