complex paths in library fields, with support for generators #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
karel/lmb-182-allow-changing-field-order
to
karel/lmb-333-create-form-extensions
January 14, 2025 12:18
JonasVanHoof
requested changes
Jan 21, 2025
| return null; | ||
| } | ||
| const b = bindings[0]; | ||
| if (b.get('shape').termType === 'BlankNode') { |
There was a problem hiding this comment.
Does rdflib not have a method isBlankNode and isLiteral?
There was a problem hiding this comment.
but right now i don't have a dependency on rdflib here i think this termType thing is according to the spec and not just rdflib so i'd rather keep it that way
JonasVanHoof
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See linked PR
Links to other PR's