Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/store public setting of treatment #138

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Bugfix/store public setting of treatment #138

merged 2 commits into from
Jun 28, 2021

Conversation

nvdk
Copy link
Member

@nvdk nvdk commented Jun 23, 2021

turns out we didn't actually save this 🤦 . ty @Asergey91 for mentioning!

@nvdk nvdk requested review from Asergey91 and abeforgit June 23, 2021 11:34
@nvdk nvdk changed the base branch from master to development June 23, 2021 11:34
@Asergey91
Copy link
Contributor

doesnt seem to work atm
something to do with the getters
this.openbaar returns undefined
while this.args.behandeling.openbaar returns the correct value

@nvdk nvdk added the bug Something isn't working label Jun 25, 2021
abeforgit
abeforgit requested changes Jun 25, 2021
View reviewed changes
Copy link
Member

@abeforgit abeforgit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to remove @tracked openbaar from the class properties when converting to a getter
classic mistake

works well once you remove that

@nvdk
remove tracked + setting this.openbaar
a7bc538 
it's just an alias for this.behandeling.openbaar anyway
@nvdk nvdk merged commit 5bade08 into development Jun 28, 2021
@nvdk nvdk deleted the bugfix/store-public-setting-of-treatment branch June 28, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeforgit abeforgit abeforgit requested changes

@Asergey91 Asergey91 Awaiting requested review from Asergey91

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvdk @Asergey91 @abeforgit