Feature/acmidm switch #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvdk
force-pushed
the
feature/acmidm-switch
branch
from
1941a74 to
a831968
Compare
nvdk
force-pushed
the
feature/acmidm-switch
branch
from
a831968 to
d1d029f
Compare
nvdk
commented
Sep 6, 2021
lagartoverde
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
I can't fully test it, I think because I'm not using acmidm, I see the switch besturseenheid button, but when I click it says it didn't find the page.
Code looks good, only thing I see it's that strings should be translated and added to the .yml files.
Good job 👍
| {{#if this.acmSwitchEnabled}} | ||
| <Acmidm::Switch as |acmidm|> | ||
| <AuButton @loading={{acmidm.isSwitching}} class="au-c-button au-c-button--tertiary" role="menuitem" {{on "click" acmidm.switch}}> | ||
| <AuIcon @icon="switch" @alignment="left" />Wissel van bestuurseenheid |
There was a problem hiding this comment.
Maybe all these strings should be translated?
|
I'm going to merge this, since it's hidden by default and needs to be tested on QA |
Dietr
added a commit
that referenced
this pull request
Sep 14, 2021
* development: fix faulty merge support switching user via acm/idm (#172) Remove requirebranch config Release 2.11.1 Add updated items to changeset notulenSet should be outside of the map Fix bug with signed resources Hide button on edit agendapoint added feature flag in environment.js linting improved component and fixed all bugs Fix notulen was not correctly reloaded under a very specific scenario Calculated status based on the actual publication status of the extract Hide attachments behind feature flag Fixed page numbers in extract publication table add styling for tables still relying on webuniversum css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test, you can enable the feature with http://localhost:4200/inbox/meetings?feature[acmidm-switch]=true