Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved flow for creating agendapoints #191

Merged
merged 6 commits into from
Sep 16, 2021
Merged

improved flow for creating agendapoints #191

merged 6 commits into from
Sep 16, 2021

Conversation

nvdk
Copy link
Member

@nvdk nvdk commented Sep 15, 2021

Some thoughts:

  • doesn't include the selection of the decision type yet, perhaps best done in another PR
  • integrates parts of the template plugin, so must make sure to keep the code in sync when updating that plugin
  • probably need to provide something similar in the agendapoint manager in the meeting itself

@nvdk nvdk added the enhancement New feature or request label Sep 15, 2021
lagartoverde
lagartoverde approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@lagartoverde lagartoverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good, only some translations are missing, good job 👍

translations/nl-BE.yaml Show resolved Hide resolved
Dietr
Dietr reviewed Sep 16, 2021
View reviewed changes
translations/nl-BE.yaml Outdated Show resolved Hide resolved
@nvdk nvdk merged commit e27a197 into development Sep 16, 2021
@nvdk nvdk deleted the feature/improved-agendapoint-creation-flow branch September 16, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lagartoverde lagartoverde lagartoverde approved these changes

@Dietr Dietr Dietr approved these changes

@Asergey91 Asergey91 Awaiting requested review from Asergey91

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvdk @Dietr @lagartoverde