Added attachments number to agendapoints table #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvdk
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
One thing to consider with this approach is that it can make the initial request heavy (and the cache will also be invalided more often). I guess it all depends on the amount of attachments we can expect, if it's low this will work ok.
Personally I would have gone with a separate component that fetches the attachment count for each line, but this looks fine to merge as is at the moment.
nvdk
reviewed
Oct 13, 2021
nvdk
requested changes
Oct 13, 2021
nvdk
approved these changes
Oct 13, 2021
Dietr
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe do we need some design for that number? @Dietr
If not feel free to approve and merge :)