Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add article to bestuursorgan #209

Merged
merged 7 commits into from
Oct 13, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,38 @@



## 2.18.0 (2021-10-06)

#### :rocket: Enhancement
* [#204](https://github.com/lblod/frontend-gelinkt-notuleren/pull/204) Only save document if it's in a dirty state ([@lagartoverde](https://github.com/lagartoverde))
* [#203](https://github.com/lblod/frontend-gelinkt-notuleren/pull/203) Change column order in attachments table ([@lagartoverde](https://github.com/lagartoverde))
* [#202](https://github.com/lblod/frontend-gelinkt-notuleren/pull/202) Add numbering to agendapoints in intermission select and fixed ordering ([@lagartoverde](https://github.com/lagartoverde))
* [#201](https://github.com/lblod/frontend-gelinkt-notuleren/pull/201) Add tooltip on attachment button ([@Dietr](https://github.com/Dietr))

#### :house: Internal
* [#199](https://github.com/lblod/frontend-gelinkt-notuleren/pull/199) bump ember auto import ([@nvdk](https://github.com/nvdk))

#### Committers: 3
- Dieter Peirs ([@Dietr](https://github.com/Dietr))
- Niels V ([@nvdk](https://github.com/nvdk))
- Oscar Rodriguez Villalobos ([@lagartoverde](https://github.com/lagartoverde))

## 2.17.0 (2021-09-24)

#### :rocket: Enhancement
* [#197](https://github.com/lblod/frontend-gelinkt-notuleren/pull/197) added an overview of attachments in meeting interface ([@Asergey91](https://github.com/Asergey91))
* [#193](https://github.com/lblod/frontend-gelinkt-notuleren/pull/193) Feature/enable acmidm switch ([@nvdk](https://github.com/nvdk))

#### :bug: Bug Fix
* [#198](https://github.com/lblod/frontend-gelinkt-notuleren/pull/198) Fix issue with double characters ([@abeforgit](https://github.com/abeforgit))
* [#195](https://github.com/lblod/frontend-gelinkt-notuleren/pull/195) fix editor scrolling issue ([@Dietr](https://github.com/Dietr))

#### Committers: 4
- Arne Bertrand ([@abeforgit](https://github.com/abeforgit))
- Dieter Peirs ([@Dietr](https://github.com/Dietr))
- Niels V ([@nvdk](https://github.com/nvdk))
- Sergey Andreev ([@Asergey91](https://github.com/Asergey91))

## 2.16.0 (2021-09-17)

#### :rocket: Enhancement
Expand Down
2 changes: 1 addition & 1 deletion app/components/meeting-form.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
<div class="au-c-meeting-chrome__paper">
{{!-- Meeting title --}}
<AuHeading>
{{t "meetingForm.meetingHeadingPartOne"}} <span class="au-c-meeting-chrome__highlight">{{@zitting.bestuursorgaan.isTijdsspecialisatieVan.naam}},</span>
{{t "meetingForm.meetingHeadingPartOne"}} {{t this.headerArticleTranslationString}} <span class="au-c-meeting-chrome__highlight">{{@zitting.bestuursorgaan.isTijdsspecialisatieVan.naam}},</span>
{{t "meetingForm.meetingHeadingPartTwo"}} <span class="au-c-meeting-chrome__highlight">{{moment-format @zitting.geplandeStart "DD/MM/YYYY HH:mm"}}</span>
</AuHeading>
<AuHr @size="large"/>
Expand Down
6 changes: 6 additions & 0 deletions app/components/meeting-form.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { tracked } from "@glimmer/tracking";
import { task } from "ember-concurrency";
import { inject as service } from "@ember/service";
import isValidMandateeForMeeting from 'frontend-gelinkt-notuleren/utils/is-valid-mandatee-for-meeting';
import { articlesBasedOnClassifcationMap } from '../utils/classification-utils';

/** @typedef {import("../models/agendapunt").default[]} Agendapunt */

Expand All @@ -16,6 +17,7 @@ export default class MeetingForm extends Component {
@tracked bestuursorgaan;
@tracked possibleParticipants;
@tracked behandelingen;
@tracked headerArticleTranslationString = '';
@service store;
@service currentSession;
@service router;
Expand All @@ -39,6 +41,10 @@ export default class MeetingForm extends Component {
*loadData() {
if (this.zitting.get("id")) {
this.bestuursorgaan = yield this.zitting.get("bestuursorgaan");
const specialisedBestuursorgaan = yield this.bestuursorgaan.get("isTijdsspecialisatieVan");
const classification = yield specialisedBestuursorgaan.get('classificatie');
this.headerArticleTranslationString = articlesBasedOnClassifcationMap[classification.get('uri')];
console.log(this.headerArticleTranslationString);
this.secretaris = yield this.zitting.get("secretaris");
this.voorzitter = yield this.zitting.get("voorzitter");
yield this.fetchParticipants.perform();
Expand Down
27 changes: 27 additions & 0 deletions app/utils/classification-utils.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
const BURGEMEESTER = 'http://data.vlaanderen.be/id/concept/BestuursorgaanClassificatieCode/4955bd72cd0e4eb895fdbfab08da0284';
const COLLEGE_VAN_BURGEMEESTER_EN_SCHEPENEN = 'http://data.vlaanderen.be/id/concept/BestuursorgaanClassificatieCode/5ab0e9b8a3b2ca7c5e000006';
const VOORZITTER_VAN_DE_RAAD_VOOR_MAATSCHAPPELIJK_WELZIJN = 'http://data.vlaanderen.be/id/concept/BestuursorgaanClassificatieCode/e14fe683-e061-44a2-b7c8-e10cab4e6ed9';
const GEMEENTERAAD = 'http://data.vlaanderen.be/id/concept/BestuursorgaanClassificatieCode/5ab0e9b8a3b2ca7c5e000005';
const RAAD_VOOR_MAATSCHAPPELIJK_WELZIJN = 'http://data.vlaanderen.be/id/concept/BestuursorgaanClassificatieCode/5ab0e9b8a3b2ca7c5e000007';
const VOORZITTER_VAN_DE_GEMEENTERAAD = 'http://data.vlaanderen.be/id/concept/BestuursorgaanClassificatieCode/4c38734d-2cc1-4d33-b792-0bd493ae9fc2';
const BIJZONDER_COMITE_VOOR_DE_SOCIALE_DIENST = 'http://data.vlaanderen.be/id/concept/BestuursorgaanClassificatieCode/5ab0e9b8a3b2ca7c5e000009';
const DEPUTATIE = 'http://data.vlaanderen.be/id/concept/BestuursorgaanClassificatieCode/5ab0e9b8a3b2ca7c5e00000d';
const GOUVERNEUR = 'http://data.vlaanderen.be/id/concept/BestuursorgaanClassificatieCode/180a2fba-6ca9-4766-9b94-82006bb9c709';
const PROVINCIERAAD = 'http://data.vlaanderen.be/id/concept/BestuursorgaanClassificatieCode/5ab0e9b8a3b2ca7c5e00000c';
const VOORZITTER_VAN_HET_BIJZONDER_COMITE_VOOR_DE_SOCIALE_DIENST = 'http://data.vlaanderen.be/id/concept/BestuursorgaanClassificatieCode/53c0d8cd-f3a2-411d-bece-4bd83ae2bbc9';
const VAST_BUREAU = 'http://data.vlaanderen.be/id/concept/BestuursorgaanClassificatieCode/5ab0e9b8a3b2ca7c5e000008';

export const articlesBasedOnClassifcationMap = {
[BURGEMEESTER]: 'meetingForm.meetingHeadingArticleGendered',
[COLLEGE_VAN_BURGEMEESTER_EN_SCHEPENEN]: 'meetingForm.meetingHeadingArticleUngendered',
[VOORZITTER_VAN_DE_RAAD_VOOR_MAATSCHAPPELIJK_WELZIJN]: 'meetingForm.meetingHeadingArticleGendered',
[GEMEENTERAAD]: 'meetingForm.meetingHeadingArticleGendered',
[RAAD_VOOR_MAATSCHAPPELIJK_WELZIJN]: 'meetingForm.meetingHeadingArticleGendered',
[VOORZITTER_VAN_DE_GEMEENTERAAD]: 'meetingForm.meetingHeadingArticleGendered',
[BIJZONDER_COMITE_VOOR_DE_SOCIALE_DIENST]: 'meetingForm.meetingHeadingArticleUngendered',
[DEPUTATIE]: 'meetingForm.meetingHeadingArticleGendered',
[GOUVERNEUR]: 'meetingForm.meetingHeadingArticleGendered',
[PROVINCIERAAD]: 'meetingForm.meetingHeadingArticleGendered',
[VOORZITTER_VAN_HET_BIJZONDER_COMITE_VOOR_DE_SOCIALE_DIENST]: 'meetingForm.meetingHeadingArticleGendered',
[VAST_BUREAU]: 'meetingForm.meetingHeadingArticleUngendered'
};
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "frontend-gelinkt-notuleren",
"version": "2.16.0",
"version": "2.18.0",
"private": true,
"description": "Ember frontend of the Gelinkt Notuleren application",
"repository": {
Expand Down
4 changes: 3 additions & 1 deletion translations/en-us.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ meetingForm:
fifthSectionTitle: 5. Treatment of the agenda items
sixthSectionTitle: 6. Free text (meeting outro).
seventhSectionTitle: 7. End of the meeting
meetingHeadingPartOne: Meeting minutes of
meetingHeadingPartOne: Meeting minutes
meetingHeadingArticleGendered: of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the article in english would just always be "the", but this is fine too :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about this also, but I feel just "of" is better

meetingHeadingArticleUngendered: of
meetingHeadingPartTwo: of
firstSectionNotFilledWarning: Before you can start the meeting it is necessary to set a date, location and governing body.
secondSectionNotFilledWarning: Complete the attendance.
Expand Down
2 changes: 2 additions & 0 deletions translations/nl-BE.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ meetingForm:
sixthSectionTitle: 6. Einde van de zitting
seventhSectionTitle: 7. Beëindiging van de zitting
meetingHeadingPartOne: Notulen van
meetingHeadingArticleGendered: de
meetingHeadingArticleUngendered: het
meetingHeadingPartTwo: van
firstSectionNotFilledWarning: Voor je kan starten met de zitting is het nodig om een datum, locatie en bestuursorgaan in te stellen.
secondSectionNotFilledWarning: Zorg ervoor dat je de aanwezigenlijst correct aanvult voor je aan de stemmingen begint.
Expand Down