Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add hash to printview #210

Merged
merged 6 commits into from
Oct 13, 2021
Merged

Feature/add hash to printview #210

merged 6 commits into from
Oct 13, 2021

Conversation

lagartoverde
Copy link
Contributor

No description provided.

@lagartoverde lagartoverde requested review from nvdk and Dietr October 13, 2021 10:57
@lagartoverde
Copy link
Contributor Author

Screen Shot 2021-10-13 at 12 56 13

Looks like this, I guess we don't have to add styling as the other parts are not styled either

@nvdk nvdk added the enhancement New feature or request label Oct 13, 2021
nvdk
nvdk reviewed Oct 13, 2021
View reviewed changes
app/components/print-view/signature.hbs Outdated
@@ -1,4 +1,5 @@
<div class="au-o-grid__item au-u-1-2@medium">
<AuHeading @level="3" @skin="6" class="au-u-margin-bottom-tiny">Ondertekend door</AuHeading>
<p>{{@fullName}} <br> {{moment-format @createdOn 'L LT'}}</p>
<p>Hash: {{@hashValue}}</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd drop the Hash:

@nvdk nvdk merged commit 590b4ae into development Oct 13, 2021
@nvdk nvdk deleted the feature/add-hash-to-printview branch October 13, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvdk nvdk nvdk left review comments

@Dietr Dietr Dietr approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lagartoverde @nvdk @Dietr