Bugfix/agendapoint ordering #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was pretty easy to get the db in an inconsistent state by cancelling the save/delete tasks halfway through. (for example by clicking outside the modal while the tasks were running). Because save and delete happen in steps (because of lacking support for cascading in ED) this could cause problems since child tasks are linked by default.
nvdk
reviewed
Nov 8, 2021
| @@ -180,10 +181,15 @@ export default class AgendaManagerAgendaContextComponent extends Component { | |||
| if(item.position !== index || previousItem !== previous) { | |||
| this.setProperty(item, "position", index); | |||
| this.setProperty(item, "vorigeAgendapunt", previous); | |||
| const treatment = yield item.treatment; | |||
| const treatment = yield item.behandeling; | |||
There was a problem hiding this comment.
yikes, does this mean the order of treatments was never correctly saved?
looks like it will always be set to null. Guessing that since we don't use it, it hardly changes much: https://github.com/lblod/notulen-prepublish-service/blob/5e95f3c3601e20b87c05b7f5e85938ce560da9ad/models/treatment.js#L31
There was a problem hiding this comment.
it is used here: https://github.com/lblod/notulen-prepublish-service/blob/5e95f3c3601e20b87c05b7f5e85938ce560da9ad/models/treatment.js#L75, so possible incorrect info when an extract is published
nvdk
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
I'm guessing this will mitigate most issues, so this can be merged.
Couple of remarks:
- I guess it would make more sense if we could block closing the modal until our tasks are done
- if a user closes the modal before these tasks are done, will the UI look ok to them (e.g. even though the tasks haven't finished yet will they see the correct info... I'm guessing yes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probably fixes https://binnenland.atlassian.net/browse/GN-3037
It's hard to exactly reproduce the problem, but this pr solves 2 database inconsistency issues related to agendapoint ordering logic.
Imo the most likely cause was closing the modal while the update/delete tasks were still running.
Due to (once again) machty/ember-concurrency#161 this can easily cause inconsistent database state. (e.g. an agenda-item without treatment)