Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added validation to meeting end date/time #276

Merged
merged 2 commits into from
May 19, 2022
Merged

added validation to meeting end date/time #276

merged 2 commits into from
May 19, 2022

Conversation

Asergey91
Copy link
Contributor

@Asergey91 Asergey91 commented May 16, 2022 •
edited
Loading

solves GN-3418

@Asergey91 Asergey91 requested review from nvdk and lagartoverde May 16, 2022 13:55
nvdk
nvdk requested changes May 16, 2022
View reviewed changes
Copy link
Member

@nvdk nvdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails on linting rules, I recommend setting up prettier in your editor or adding the lint check to your git pre-commit hook

lagartoverde
lagartoverde approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@lagartoverde lagartoverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the listing error is gone 👍

@Asergey91 Asergey91 merged commit 7008261 into development May 19, 2022
@Asergey91 Asergey91 deleted the bugfix/meeting-date-validation branch May 19, 2022 15:20
@Asergey91 Asergey91 added the enhancement New feature or request label May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvdk nvdk nvdk requested changes

@lagartoverde lagartoverde lagartoverde approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Asergey91 @nvdk @lagartoverde