Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update package version of citaten-plugin: fixes confirmation popup on leaving edit route #289

Merged
merged 1 commit into from
Jun 15, 2022
Merged

update package version of citaten-plugin: fixes confirmation popup on leaving edit route #289

merged 1 commit into from
Jun 15, 2022

Conversation

elpoelma
Copy link
Contributor

This update fixes an issue with willDestroy-hooks not being triggered as the previous version of this package caused an exception.

@elpoelma elpoelma added bug Something isn't working dependencies Pull requests that update a dependency file labels Jun 15, 2022
abeforgit
abeforgit approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just merge this I think

@elpoelma elpoelma merged commit cd6a872 into development Jun 15, 2022
@elpoelma elpoelma deleted the fix/confirm-dialog branch June 15, 2022 09:07
@nvdk nvdk changed the title update package version of citaten-plugin update package version of citaten-plugin: fixes confirmation popup on leaving edit route Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeforgit abeforgit abeforgit approved these changes

Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elpoelma @abeforgit