Create revision layout #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Release 2.28.1 fixed according to review notes initial commit push latest based on development Release 2.28.0 Release 2.27.1 linting use paper view for intro and outro editor moved logic which determines whether delete button is shown or not removed publicatie-agendas freom include in query remove console log added validation which enables/disables the delete button of a meeting based on the number of attached published resources bump ember promise helpers to 2.0.0 bump ay11-refocus to 3.0.0 Release 2.27.0 Release 2.26.0 Release 2.25.1 Release 2.25.0 Release 2.24.0
|
Works well overall, maybe the 'Bestand acties' dropdown could contain entries in order to export the html of the current version or remove a specific version. Additionally, it would be nice that the 'Herstel versie' button is disabled when the most recent version is selected. |
* master: allow clearing the secretary Release 2.28.2 bump editor to 0.60.3 (#305) bump citation-plugin to 0.17.4 only include relevant plugins for intro and outro text (#302) bump ember-rdfa-editor-rdfa-date-plugin to 0.2.1 (#301) bump editor to 0.60.1, required for citation plugin bump @lblod/ember-rdfa-editor-citaten-plugin to 0.17.3
abeforgit
force-pushed
the
feature/rework-revision
branch
from
d6b7901 to
5a43bd7
Compare
…chments move attachments logic to its own route and clean up appchrome
also make them actually do the required things and add some translations
…into feature/rework-revision
since we now use named blocks, have to update the use for regulatory statements as well
nvdk
force-pushed
the
feature/rework-revision
branch
from
249a74d to
d2eed91
Compare
|
the custom edit view in meeting is now gone, I've discussed this with dieter. two things I've noticed:
|
emacs does this sometimes 🤷
…elinkt-notuleren into feature/rework-revision
nvdk
reviewed
Oct 12, 2022
| @@ -89,6 +85,7 @@ export default class AgendapointsEditController extends Controller { | |||
| editorDocument.updatedOn = new Date(); | |||
| editorDocument.title = this.editorDocument.title; | |||
| editorDocument.previousVersion = this.editorDocument; | |||
| editorDocument.documentContainer = this.documentContainer; | |||
There was a problem hiding this comment.
this might get lost in the big lump, but this is a bug that will need a migration to correct on all environments. There's supposed to be a direct link between any version and the container and that was no longer being set.
a parent route is not reloaded when switching between child routes, since we loaded currentVersion there this could become outdated after a save. This in turn caused unexpected behaviour when switching between subroutes (e.g. revisions and edit), where either fewer revisions were shown than actually existed or an older version of the document was shown when returning to the edit route
nvdk
force-pushed
the
feature/rework-revision
branch
from
f13cdc6 to
0ea7256
Compare
I created a solution in order to prevent the double warnings on #342 . |
Fix: prevent the confirm dialog to show up twice when exiting without saving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the revision page to fit into the design.
Needs dev work/help