fetch decision types from centrale vindplaats #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the TTL files that are being replaced by fetching the BesluitTypes direclty from a SPARQL endpoint. This includes having to change the Webpack configuration and to add a package `process` as a devDependency.
This is to make the besluit-type-plugin work, fetching besluit-types from an endpoint.
|
No idea why the Drone integration testing failed before (it complained about Missing npm packages, while it is supposed to do an |
nvdk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old TTL files with the data about the BesluitTypes. The data will be fetched from a SPARQL endpoint in the future. The new besluit-type-plugin (not released yet) will do this.
It also has to include some Webpack configuration copied from ember-rdfa-editor-besluit-type-plugin to package module
process. All tested vianpm linkand it seems to work.NOTE:
index.html.