-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter based on validThrough property #333
Filter based on validThrough property #333
Conversation
I would say no matter what we do, I would compare the dates. Like you said that should have the same effect since we're only setting current date when deleting, but just imagine we come back to this in 2 months time and see a property called "validThrough", we'd expect it to work as the name implies. |
… backend PR is merged
the pr you mentioned is now merged and deployed on dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it just kinda doesn't work, deleted templates still show up
It should work now I fixed a typo in the query, also there's a looong waiting time for the cache |
you can just go to the server and restart the sparql-cache service, that's what I've been doing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works now
…d-on-valid-throught
First of all this depends on lblod/reglement-publish-service#5 so we should wait for that to be merged and deployed, but I created the PR so we can start a little discussion.
I did the most basic thing, if the reglement has an expiration date not show it, I was thinking on filtering based on the ones that are still valid (even thought we don't really set this validthrough date in the future, we just set it to today when we delete in the regulatory statements app). This would be more semantically correct, but also would bring the question: "Do we want to allow the user to include a template that will expire tomorrow, in the next week...?", I think that for the moment is better to leave it like this and improve the flow in the future, but it's open for discussion