fix deprecations #344
Merged
fix deprecations #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvdk
approved these changes
Oct 17, 2022
abeforgit
requested changes
Oct 17, 2022
There was a problem hiding this comment.
Looks good, but I spotted a few more:
missed deprecations in the following pages:
- inbox/trash route: implicit store injection
- meetings//publish/uittreksels: implicit store injection
- all publication pages: alertIcon, alertTitle and alertSkin. To be investigated
Remaining deprecations that need further investigation, but are probably not our fault:
- ember-modifier related deprecations on almost every page
- deprecation in "draggable-object.hbs", probably coming from
ember-drag-drop
Some remaining deprecations come from the editor:
- Appuniversum "AuToolbar" and "AuList" deprecations on pages with an editor
…, meetings/publish/uittreksels: implicit store injection, all publication pages: alertIcon, alertTitle and alertSkin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.