Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use file service from regulatory-statements application in order to fetch template #348

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Use file service from regulatory-statements application in order to fetch template #348

merged 2 commits into from
Oct 20, 2022

Conversation

elpoelma
Copy link
Contributor

This PR includes changes on how the regulatory statement templates are fetched:

  • The SPARQL query used to fetch a template has been modified in order to conform to the new data model.
  • The template content is now fetched from the regulatory statements file service instead of the custom preview endpoint.
  • The regulatoryStatementPreviewEndpoint environment variable has been removed and replaced in favor of regulatoryStatementFileEndpoint. Both regulatory-statement endpoint ENV vars have been set to fetch from localhost in order to test this PR.

This PR relies on lblod/app-reglementaire-bijlage#27.
This PR is a solution to https://binnenland.atlassian.net/jira/software/c/projects/GN/boards/4?modal=detail&selectedIssue=GN-3732.

TODO:

  • The SPARQL query should be updated with the correct namespaces (instead of ext).

@elpoelma elpoelma self-assigned this Oct 19, 2022
@elpoelma elpoelma marked this pull request as draft October 19, 2022 09:00
@elpoelma elpoelma added the enhancement New feature or request label Oct 19, 2022
@elpoelma elpoelma marked this pull request as ready for review October 20, 2022 13:41
lagartoverde
lagartoverde approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@lagartoverde lagartoverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, remember to change the config when deploying

@lagartoverde
Copy link
Contributor

We still have to think about the reload problem, but I think that's not the point of this PR

@elpoelma elpoelma merged commit 89f76ee into master Oct 20, 2022
@elpoelma elpoelma deleted the feature/regulatory-statements-file-service branch October 20, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lagartoverde lagartoverde lagartoverde approved these changes

@abeforgit abeforgit Awaiting requested review from abeforgit

Assignees

@elpoelma elpoelma

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elpoelma @lagartoverde