Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export-to-html menu action to regulatory-statements document view #349

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma added the enhancement New feature or request label Oct 19, 2022
@elpoelma elpoelma changed the title Add export to html menu action to regulatory-statements document view Add export-to-html menu action to regulatory-statements document view Oct 19, 2022
@elpoelma elpoelma self-assigned this Oct 19, 2022
@abeforgit
Copy link
Member

Some notes, which may or may not be an issue:

  • table of contents does not get exported
  • we lose the lblodgn:ReglementaireBijlagen type, since that type is defined outside the editor root. this is probably fine, and will improve when we rework the way we do types in documents

@elpoelma
Copy link
Contributor Author

Some notes, which may or may not be an issue:

* table of contents does not get exported

* we lose the `lblodgn:ReglementaireBijlagen` type, since that type is defined outside the editor root. this is probably fine, and will improve when we rework the way we do types in documents

Current the ToC does indeed not yet get exported. I still need to merge the static export feature.

@abeforgit
Copy link
Member

imo you can merge without it

@elpoelma elpoelma merged commit 413388b into master Oct 21, 2022
@elpoelma elpoelma deleted the feature/export-regulatory-statement branch October 21, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants