Fix issue with voting overview page where the number of votings are limited to 20 #353
Conversation
| 'filter[behandeling-van-agendapunt][:id:]': this.args.behandeling.id, | ||
| sort: 'position', | ||
| page: { | ||
| size: pageSize, |
There was a problem hiding this comment.
Wouldn't be easier to fetch with an absurd pageSize? like 999
There was a problem hiding this comment.
Yeah I'm still hesitating what the best approach is.
There was a problem hiding this comment.
might be interesting to abstract out this logic, seems useful to have a generic "get all" for paginated endpoints
We could probably get away with increasing the pagesize here since even 30 votings is already exceptional, but it's good to be diligent.
Actually we just need a serious solution for pagination, which can handle all cases
| 'filter[behandeling-van-agendapunt][:id:]': this.args.behandeling.id, | ||
| sort: 'position', | ||
| page: { | ||
| size: pageSize, |
There was a problem hiding this comment.
might be interesting to abstract out this logic, seems useful to have a generic "get all" for paginated endpoints
We could probably get away with increasing the pagesize here since even 30 votings is already exceptional, but it's good to be diligent.
Actually we just need a serious solution for pagination, which can handle all cases
This PR includes two fixes:
This PR is to be used in combination with: lblod/app-gelinkt-notuleren#118 and solves https://binnenland.atlassian.net/jira/software/c/projects/GN/boards/4?modal=detail&selectedIssue=GN-3798