Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: decision regulatory statement coupling #355

Merged
merged 28 commits into from
Nov 7, 2022

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Nov 4, 2022

This PR includes a new in-app editor-plugin which allows users to insert regulatory statements in decisions. Specifically, the PR includes the following features:

  • A modal which allows users to select and insert a regulatory statement in a decision.
  • The regulatory statements are inserted as inline components in the editor document, they will always show the latest version of the included regulatory statement. The regulatory statements also have a static representation, which is an rdfa-annotated link to the linked regulatory statement container. The included regulatory statements are annotated with the https://data.vlaanderen.be/doc/applicatieprofiel/besluit-publicatie#Documentonderdeel type and dct:hasPart predicate.

TODO:

  • Currently, a link between the regulatory statements and agendapoint document models is not stored yet. This PR includes commented code which allows storing such links, but we should further investigate how exactly we stored these links and if the relations should be many-to-many or one-to-many.
  • Styling of the sidebar of the modal in which users can select regulatory statements.
  • Addition of pagination to the modal
  • At the moment it is still possible to include a regulatory statement twice in a document, this should probably be prevented.
  • Investigate on how the publishing flow will work.

This PR is to be used in combination with lblod/ember-rdfa-editor#444 and lblod/app-gelinkt-notuleren#119

This PR is a solution to https://binnenland.atlassian.net/jira/software/c/projects/GN/boards/4?modal=detail&selectedIssue=GN-3725.

@elpoelma elpoelma marked this pull request as ready for review November 7, 2022 08:21
@abeforgit abeforgit merged commit d08bcc8 into master Nov 7, 2022
@abeforgit abeforgit deleted the feature/decision_regulatory_statement_coupling branch November 7, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants