Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the notulen is published disable the editing #361

Merged
merged 3 commits into from
Nov 11, 2022

Conversation

lagartoverde
Copy link
Contributor

Solves https://binnenland.atlassian.net/browse/GN-3640, I saw the issue and was simple so I implemented it, this has to be revisited if we implement the ability to republish a meeting, but for the moment it prevents confusion by the user.
@Dietr I used a simple design to show the user that a notulen has been published, just a pill on every heading, maybe you want to modify that
Screen Shot 2022-11-08 at 13 41 28

@lagartoverde lagartoverde added the enhancement New feature or request label Nov 8, 2022
@lagartoverde lagartoverde self-assigned this Nov 8, 2022
@Dietr
Copy link
Contributor

Dietr commented Nov 8, 2022

I would put a single pill in the header to notify that it's published. Then we don't need to repeat it on every title and it follows the article pattern.

@lagartoverde
Copy link
Contributor Author

In the header you mean next to the "Meeting scheduled..." text?

Copy link
Contributor

@elpoelma elpoelma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, I agree with Dieter that we should move the Notulen gepubliceerd pill to the header of the document.

@lagartoverde lagartoverde merged commit 99f3cf0 into master Nov 11, 2022
@lagartoverde lagartoverde deleted the feature/read-only-on-published-notulen branch November 11, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants