Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/minor improvements #362

Merged
merged 4 commits into from
Nov 9, 2022
Merged

Feature/minor improvements #362

merged 4 commits into from
Nov 9, 2022

Conversation

lagartoverde
Copy link
Contributor

Fixed some problems I discovered on GN

Screen.Recording.2022-11-08.at.13.42.25.mov

@lagartoverde lagartoverde added the enhancement New feature or request label Nov 8, 2022
@lagartoverde lagartoverde self-assigned this Nov 8, 2022
nvdk
nvdk requested changes Nov 8, 2022
View reviewed changes
Copy link
Member

@nvdk nvdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with moving the queryparams to the edit route as done here, since it breaks app chrome on all the other subroutes (show, attachments and revisions)

@lagartoverde
Copy link
Contributor Author

I don't agree with moving the queryparams to the edit route as done here, since it breaks app chrome on all the other subroutes (show, attachments and revisions)

yes sorry, my bad, I didn't even see it was already implemented on other routes, this problem was due to a bad merge I think

@lagartoverde lagartoverde requested a review from nvdk November 8, 2022 15:28
elpoelma
elpoelma approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@elpoelma elpoelma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@nvdk nvdk merged commit 4d7d028 into master Nov 9, 2022
@nvdk nvdk deleted the feature/minor-improvements branch November 9, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpoelma elpoelma elpoelma approved these changes

@abeforgit abeforgit Awaiting requested review from abeforgit

@nvdk nvdk Awaiting requested review from nvdk

Assignees

@lagartoverde lagartoverde

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lagartoverde @nvdk @elpoelma