Don't allow participant list insertion if the chairman is not present #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeforgit
requested changes
Dec 16, 2022
| @@ -5,6 +5,14 @@ | |||
| as |Modal|> | |||
| <Modal.Body> | |||
| <div class="au-o-flow"> | |||
| {{#if this.error}} | |||
There was a problem hiding this comment.
I would put this error next to the "insert" button
atm when you are scrolled down, you don't see the error and it feels like the insert button just doesnt work
abeforgit
requested changes
Dec 18, 2022
There was a problem hiding this comment.
come to think of it, wouldn't it be better to simply disable the present toggle if the mandatee = the chairman?
We have no backup flow for when they do set the chairman as absent, we simply don't allow them to proceed. So why even have the option in the first place?
edit: looking at the ticket, that seems to be what they're asking anyway
|
I have made the changes you suggested, also kept the message and moved the error just in case, or if we want to add more errors to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.