hotfix: remove empty decisions from document on save #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvdk
reviewed
Dec 20, 2022
app/controllers/agendapoints/edit.js
Outdated
| const body = parsedHtml.body.childNodes; | ||
|
|
||
| for (const child of body) { | ||
| if (child.attributes?.typeof?.textContent.includes('besluit:Besluit')) { |
There was a problem hiding this comment.
I would check for both the prefixed and full URI here.
There was a problem hiding this comment.
@nvdk please let me know if new commit address your concern ?
nvdk
reviewed
Dec 20, 2022
elpoelma
approved these changes
Dec 21, 2022
abeforgit
requested changes
Dec 21, 2022
There was a problem hiding this comment.
This only checks the top level children of the document. What if the div in question is further down the tree?
As we mentioned in the standup, there is https://developer.mozilla.org/en-US/docs/Web/API/Document/querySelectorAll which will probably be useful here
abeforgit
pushed a commit
that referenced
this pull request
Dec 21, 2022
* hotfix: remove empty decisions from document on save * add check for both the prefixed and full URI * use querySelectorAll in removeEmptyDivs Co-authored-by: Elena Poelman <[email protected]> Co-authored-by: Arne Bertrand <[email protected]> (cherry picked from commit c80445d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent users from being able to create “faulty” documents by copy pasting etc, we would remove decisions that don’t have any content from the document when saving.