Pass sort to the backend on uittreksels publication table #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvdk
reviewed
Dec 20, 2022
| @@ -21,6 +21,7 @@ export default class MeetingsPublishUittrekselsRoute extends Route { | |||
| const query = { | |||
| include: 'behandeling.versioned-behandeling', | |||
| filter: { zitting: { ':id:': this.meetingId } }, | |||
| sort: params.sort, | |||
There was a problem hiding this comment.
we're also not passing page and size, best to add those as well.
- we might want to check if this is also an issue on other routes.
abeforgit
pushed a commit
that referenced
this pull request
Dec 21, 2022
* Pass sort to the backend on uittreksels publication table * pass also pagination params (cherry picked from commit 8f3754c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.