Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ember-data to 3.28.13 #431

Merged
merged 23 commits into from
May 31, 2023
Merged

update ember-data to 3.28.13 #431

merged 23 commits into from
May 31, 2023

Conversation

lagartoverde
Copy link
Contributor

Seems to solve the problems with the participation list, https://binnenland.atlassian.net/browse/GN-4118

@lagartoverde lagartoverde self-assigned this Feb 22, 2023
elpoelma
elpoelma requested changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@elpoelma elpoelma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secretaries of a meeting are not correctly fetched. The following error is displayed:
image

@elpoelma elpoelma self-requested a review February 22, 2023 13:48
@nvdk
Copy link
Member

nvdk commented Feb 27, 2023

I think it would be better to await the functionaris higher up in the power select or make sure it's loaded in loadData

abeforgit
abeforgit requested changes May 5, 2023
View reviewed changes
app/models/functionaris.js Outdated Show resolved Hide resolved
app/components/participation-list.hbs Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@elpoelma elpoelma marked this pull request as draft May 8, 2023 09:06
@elpoelma elpoelma changed the title updated ember-data to 3.28.12 update ember-data to 3.28.13 May 8, 2023
@elpoelma elpoelma changed the base branch from master to internal/clean-up-ember-data-models May 18, 2023 10:12
@lagartoverde
Copy link
Contributor Author

@elpoelma is this finished? Because it looks good to me, and it works, so if it is, you can merge

@elpoelma
Copy link
Contributor

@elpoelma is this finished? Because it looks good to me, and it works, so if it is, you can merge

It should be mostly finished now, as I couldn't find any big other issues. I'll convert it to a PR.

@elpoelma elpoelma marked this pull request as ready for review May 22, 2023 07:14
@elpoelma elpoelma requested review from abeforgit and nvdk and removed request for elpoelma May 22, 2023 07:14
@elpoelma elpoelma requested a review from x-m-el May 22, 2023 07:15
@elpoelma
Copy link
Contributor

elpoelma commented May 22, 2023 •
edited
Loading

Note: the functionaris model does not inherit from the mandataris model. Before this PR, an incorrect inverse property of the isBestuurlijkeAliasVan relation of functionaris was used, which causes issues newer versions of ember-data. In reality, the isBestuurlijkeAliasVan relation of functionaris has no inverse.

@elpoelma elpoelma requested review from elpoelma and removed request for elpoelma May 22, 2023 07:18
@elpoelma
Copy link
Contributor

I think it would be better to await the functionaris higher up in the power select or make sure it's loaded in loadData

I agree, I will try to look into this in this PR, or a future PR.

@elpoelma
Copy link
Contributor

I think it would be better to await the functionaris higher up in the power select or make sure it's loaded in loadData

I agree, I will try to look into this in this PR, or a future PR.

I honestly also don't see why the await would be needed, as the functionaris-models are already resolved in the loadData function.

@elpoelma elpoelma self-requested a review May 24, 2023 07:04
abeforgit
abeforgit requested changes May 24, 2023
View reviewed changes
Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • some problem with inverses when loading the people present at the meeting
    image

kind of breaks the whole meeting page

@abeforgit abeforgit mentioned this pull request May 24, 2023
Merged
@elpoelma
Copy link
Contributor

  • some problem with inverses when loading the people present at the meeting
    image

kind of breaks the whole meeting page

should be resolved now, see #462 (comment)

@elpoelma elpoelma requested a review from abeforgit May 25, 2023 07:22
abeforgit
abeforgit requested changes May 25, 2023
View reviewed changes
Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting this error when trying to open an agenda publication preview:
image

@abeforgit abeforgit mentioned this pull request May 30, 2023
Merged
Base automatically changed from internal/clean-up-ember-data-models to master May 31, 2023 07:09
@elpoelma elpoelma requested a review from abeforgit May 31, 2023 07:30
@elpoelma elpoelma force-pushed the internal/update-ember-data branch from e541156 to de5ea45 Compare May 31, 2023 09:46
@abeforgit abeforgit enabled auto-merge May 31, 2023 11:25
@abeforgit abeforgit merged commit 50c3f1c into master May 31, 2023
@abeforgit abeforgit deleted the internal/update-ember-data branch May 31, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usrtim usrtim Awaiting requested review from usrtim

@nvdk nvdk Awaiting requested review from nvdk

@x-m-el x-m-el Awaiting requested review from x-m-el

@elpoelma elpoelma Awaiting requested review from elpoelma

@abeforgit abeforgit Awaiting requested review from abeforgit

Assignees

@lagartoverde lagartoverde

Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lagartoverde @nvdk @elpoelma @abeforgit