Fix schema of zitting-text component #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few different missing marks to the
zitting-text-document-containercomponent. These missing marks were causing errors when opening the meetingintrooroutromodals. The toolbar tried to display widgets which used marks which were not included in the schema. Maybe an idea: we could check for the existing of the node_spec/mark_spec a widget uses inside the widget itself, so it disables itself when the mark/node spec is not defined.Additionally this PR converts the dynamic
schemagetter of thezitting-text-document-containercomponent to a normal property to prevent duplicate instantiation of the schema object. This also solves https://binnenland.atlassian.net/browse/GN-4206?atlOrigin=eyJpIjoiYjRjYTU2ZDhiMzYzNDgwNDgyY2UxNjMyNjFmOTA5ZDkiLCJwIjoiaiJ9.