Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ember 4.8.5 #474

Merged
merged 20 commits into from
Jun 12, 2023
Merged

Upgrade to ember 4.8.5 #474

merged 20 commits into from
Jun 12, 2023

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Jun 1, 2023

This PR includes an upgrade to ember-source 4.8.5 and ember-data 4.8.8.

Specifically it updates the following packages:

  • ember source to 4.8.5 + related packages
  • ember-data to 4.8.8
  • @lblod/ember-mock-login to 0.7.0
  • ember-drag-drop to 0.9.0-beta.0

Additionally, it removes the following obsolete packages:

  • ember-load, an application-loading template is used instead
  • ember-cached-decorator-polyfill, included in ember 4.8
  • ember-functions-as-helper-polyfill, included in ember 4.8
  • ember-unique-id-helper-polyfilll, included in ember 4.8

Additionally, this PR includes a fix which first awaits all participants of an agendapoint treatment, before loading them as voters.

@elpoelma elpoelma self-assigned this Jun 1, 2023
@nvdk
Copy link
Member

nvdk commented Jun 1, 2023

while not strictly necessary, I'd recommend upgrading the ember version in the docker file and woodpecker pipelines
( I'd suggest trying madnificent/ember:4.12.1-node_18 and danlynn/ember-cli:4.12.1-node_18.16)

Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried all the flows I could think of, couldn't find anything else
good to go when CI passes

@elpoelma elpoelma merged commit 8075b40 into master Jun 12, 2023
@elpoelma elpoelma deleted the internal/upgrade-to-ember-4 branch June 12, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants