Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place the date on the right of the signer #494

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Place the date on the right of the signer #494

merged 1 commit into from
Jun 20, 2023

Conversation

lagartoverde
Copy link
Contributor

@lagartoverde lagartoverde commented Jun 20, 2023 •
edited
Loading

Overview

Changed the date on the signed resource to be placed on the left of the signer instead of the bottom

connected issues and PRs:

jira ticket
Depends on #493 just because it was easier to style without the hash block

Setup

No setup needed

How to test/reproduce

Go to a meeting, go to publish, sign whichever document you want see that the date is now placed on the left of the signer

Screen.Recording.2023-06-20.at.10.26.38.mov

Challenges/uncertainties

I'm happy with the responsive behaviour but maybe we want to put the date below in certain cases seen in the video, open for discussion

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@lagartoverde lagartoverde added the enhancement New feature or request label Jun 20, 2023
@lagartoverde lagartoverde self-assigned this Jun 20, 2023
@abeforgit
Copy link
Member

cool but its to the right, not the left, afaict :)

abeforgit
abeforgit requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change pr title (it matters cause of lerna-changelog) and you're good to merge

@lagartoverde lagartoverde changed the title Place the date of the left of the signer Place the date of the right of the signer Jun 20, 2023
@lagartoverde
Copy link
Contributor Author

cool but its to the right, not the left, afaict :)

yeah..., left, right, those things are difficult.... 😅😅😅

@lagartoverde lagartoverde changed the title Place the date of the right of the signer Place the date on the right of the signer Jun 20, 2023
@lagartoverde lagartoverde merged commit 16adb21 into feature/hide-hash-on-signed-resource Jun 20, 2023
@lagartoverde lagartoverde deleted the feature/put-date-on-the-left branch June 20, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeforgit abeforgit abeforgit requested changes

@elpoelma elpoelma Awaiting requested review from elpoelma

Assignees

@lagartoverde lagartoverde

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lagartoverde @abeforgit