-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GN-4359: improve publish page translations #496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-PR notes:
-
There are still some missing translations outside of publishing pages. I see this PR is specifically for that, but don't see a ticket for the other pages.
So I'll limit this review the publish pages and make a jira ticket for those -
any reason
'no-bare-strings': true,
in.template-lintrc.js
does not make the linting fail for all the bare strings?
Review:
Text from outside sources aren't translated. It is in Dutch (probably the main used language), so I'm not sure if this is a "real" problem. I'm guessing you can still translate these somehow, but as far as I can see not with ember-intl, so probably not trivial.
- all other (normal) translations seem to be in order. Also no typos in translations nor new bugs.
|
for backend translations issue created: |
Overview
This PR improves and fixes some of the translations on the different meeting publication pages.
connected issues and PRs:
Jira ticket
How to test/reproduce
Visit the publication pages and try to find any missing/wrong translations.
Checks PR readiness