Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4359: improve publish page translations #496

Merged
merged 9 commits into from
Jun 26, 2023

Conversation

elpoelma
Copy link
Contributor

Overview

This PR improves and fixes some of the translations on the different meeting publication pages.

connected issues and PRs:

Jira ticket

How to test/reproduce

Visit the publication pages and try to find any missing/wrong translations.

Checks PR readiness

  • UI: works on smaller screen sizes
  • npm lint

@elpoelma elpoelma requested review from abeforgit and x-m-el June 20, 2023 10:23
@elpoelma elpoelma added the bug Something isn't working label Jun 20, 2023
Copy link
Contributor

@x-m-el x-m-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-PR notes:

  • There are still some missing translations outside of publishing pages. I see this PR is specifically for that, but don't see a ticket for the other pages.
    So I'll limit this review the publish pages and make a jira ticket for those

  • any reason 'no-bare-strings': true, in .template-lintrc.js does not make the linting fail for all the bare strings?

Review:
afbeelding
Text from outside sources aren't translated. It is in Dutch (probably the main used language), so I'm not sure if this is a "real" problem. I'm guessing you can still translate these somehow, but as far as I can see not with ember-intl, so probably not trivial.

  • all other (normal) translations seem to be in order. Also no typos in translations nor new bugs.

@elpoelma
Copy link
Contributor Author

elpoelma commented Jun 26, 2023

Non-PR notes:

* There are still some missing translations outside of publishing pages. I see this PR is specifically for that, but don't see a ticket for the other pages.
  So I'll limit this review the publish pages and make [a jira ticket](https://binnenland.atlassian.net/browse/GN-4390) for those

* any reason `'no-bare-strings': true,` in `.template-lintrc.js` does not make the linting fail for all the bare strings?

Review: afbeelding Text from outside sources aren't translated. It is in Dutch (probably the main used language), so I'm not sure if this is a "real" problem. I'm guessing you can still translate these somehow, but as far as I can see not with ember-intl, so probably not trivial.

* all other (normal) translations seem to be in order. Also no typos in translations nor new bugs.
  • On the 'no-bare-strings' rule, it only fails when the template contains untranslated strings that are directly displayed, not on untranslated strings that are passed as an argument to another component for example.

  • On the text coming from the outside sources, I think we need to find a way to add some sort of internationalization on our backend services. We could probably implement it using something like this: https://www.npmjs.com/package/i18n

@elpoelma elpoelma changed the title Improve publish page translations GN-4390: improve publish page translations Jun 26, 2023
@elpoelma elpoelma changed the title GN-4390: improve publish page translations GN-4359: improve publish page translations Jun 26, 2023
@elpoelma elpoelma merged commit d9ddc0d into master Jun 26, 2023
@elpoelma elpoelma deleted the improve-publish-page-translations branch June 26, 2023 07:13
@x-m-el
Copy link
Contributor

x-m-el commented Jun 26, 2023

for backend translations issue created:
https://binnenland.atlassian.net/browse/GN-4396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants