GN-4362 fix signatures disappearing after publishing

[abeforgit]

Overview

For notulen, the VersionedNotulen you sign is not the same as the one
you publish. So I had to revert my earlier change to go back to saving
any non-empty signedresource relationships.

connected issues and PRs:

https://binnenland.atlassian.net/browse/GN-4362

Setup

How to test/reproduce

See ticket, make meeting, sign, then publish before, signature
dissapeared now, it doesnt

Challenges/uncertainties

Checks PR readiness

• UI: works on smaller screen sizes
• UI: feedback for any loading/error states
• Check cancel/go-back flows
• Check database state correct when deleting/updating (especially
  regarding relationships)
• changelog
• npm lint
• no new deprecations

[x-m-el]

It works as expected 👍

I can't really grasp the code though. Is this correct:

• first there is no versionedNotulen. a dummy versionedNotulen record is created to show instead.
• a user can then sign, which will create a signed resource (and also a versionedNotulen in the backend? What happens for a second signature?)
• Can publish, which also creates a versionedNotulen (with a publishedResource attached).

In loadNotulen:

1. if published, that notulen is always used
2. if no published but a signed notulen, that signed notulen is used
   Is there always only one signed notulen (with one or two signatures)?
3. if no signing/publish, a "dummy" notulen record is used

I think notulenSet would better be named publishedNotulenSet to make it clear why it shouldn't be set to true when set for a signedResource.

[abeforgit]

It works as expected +1

I can't really grasp the code though. Is this correct:

* first there is no versionedNotulen. a dummy versionedNotulen record is created to show instead.

* a user can then sign, which will create a signed resource (and also a versionedNotulen in the backend? What happens for a second signature?)

* Can publish, which also creates a versionedNotulen (with a publishedResource attached).

In loadNotulen:

1. if published, that notulen is always used

2. if no published but a signed notulen, that signed notulen is used
   Is there always only one signed notulen (with one or two signatures)?

3. if no signing/publish, a "dummy" notulen record is used

I think notulenSet would better be named publishedNotulenSet to make it clear why it shouldn't be set to true when set for a signedResource.

sounds about right but indeed the logic is completely bonkers
not gonna refactor it now though not enough time