Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4358: addition of a document-type filter to the publication actions page #509

Merged
merged 4 commits into from
Jul 3, 2023

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Jun 26, 2023

Overview

This PR adds a dropdown component to the publication actions page which allows users to filter on document type.
The values a user can select between are:

  • Agenda
  • Decision list
  • Extract
  • Document/Notulen
connected issues and PRs:

Jira ticket: https://binnenland.atlassian.net/browse/GN-4358?atlOrigin=eyJpIjoiOTViNmRjMzcwN2ExNGJkY2E5YTMyZTNkZDc2MzY1ODMiLCJwIjoiaiJ9
Design: https://www.figma.com/file/pW370BHe4ES5eN0vHhArA5/GN-4022?type=design&node-id=0-1&t=Ncms3NPhRgxXECZW-0

How to test/reproduce

Visit the publication actions page and select a document type using the dropdown. Only the selected document type should be shown and the pagination should reset to page 0.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint

@elpoelma elpoelma added the enhancement New feature or request label Jun 26, 2023
@elpoelma elpoelma self-assigned this Jun 26, 2023
@elpoelma elpoelma changed the base branch from master to publication-actions-design-consistency June 26, 2023 11:45
Base automatically changed from publication-actions-design-consistency to master June 26, 2023 11:59
@abeforgit
Copy link
Member

I know I'm being annoying but please stick to the jira format, so GN-4358 (will make parsing easier later)

@elpoelma elpoelma changed the title Gn 4358: addition of a document-type filter to the publication actions page GN-4358: addition of a document-type filter to the publication actions page Jun 28, 2023
Copy link
Contributor

@lagartoverde lagartoverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filtering is kept evern if you change meetings which can be confusing for the user because he can lose track of what is being filtered, apart from that everything else looks good 👍

@elpoelma
Copy link
Contributor Author

The filtering is kept evern if you change meetings which can be confusing for the user because he can lose track of what is being filtered, apart from that everything else looks good +1

Should be solved with the resetController hook.

@elpoelma elpoelma requested a review from lagartoverde June 29, 2023 09:04
@elpoelma elpoelma enabled auto-merge July 3, 2023 07:58
@elpoelma elpoelma merged commit 9d1a56f into master Jul 3, 2023
@elpoelma elpoelma deleted the GN-4358-action-log-document-type-filter branch July 3, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants