Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GN-4384: Convert deleted text in publication actions to a pill #512

Merged
merged 1 commit into from
Jun 30, 2023
Merged

GN-4384: Convert deleted text in publication actions to a pill #512

merged 1 commit into from
Jun 30, 2023

Conversation

lagartoverde
Copy link
Contributor

@lagartoverde lagartoverde commented Jun 29, 2023 •
edited
Loading

Overview

Convert the deleted text that appeared when you deleted a versioned resource to a pill so it doesn't look like we change the title of the document

connected issues and PRs:

jira ticket

Setup

None, you only will need to have deleted versioned resources in your system

How to test/reproduce

  • Create a new meeting
  • Fill the details
  • Sign an agenda
  • Delete that signature
  • Go to publication actions
  • You should see the deleted text is now a pill

Challenges/uncertainties

none

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@lagartoverde lagartoverde added the enhancement New feature or request label Jun 29, 2023
@lagartoverde lagartoverde self-assigned this Jun 29, 2023
@elpoelma elpoelma self-requested a review June 30, 2023 08:51
@elpoelma elpoelma merged commit 6e5991c into master Jun 30, 2023
@elpoelma elpoelma deleted the GN-4384-convert-deleted-to-pill branch June 30, 2023 08:52
@x-m-el x-m-el mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpoelma elpoelma elpoelma approved these changes

@abeforgit abeforgit abeforgit approved these changes

@dkozickis dkozickis Awaiting requested review from dkozickis

Assignees

@lagartoverde lagartoverde

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lagartoverde @abeforgit @elpoelma