Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4406: add support for root level articles to regulatory statement documents #519

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Jul 3, 2023

Overview

This PR adapts the schema of regulatory statement documents in order to ensure root-level articles are allowed.

connected issues and PRs:

https://binnenland.atlassian.net/browse/GN-4407?atlOrigin=eyJpIjoiYTMyOTdkMzg4MjY0NDUwNWJmMjlkMWM4NzViOThlZjYiLCJwIjoiaiJ9
https://binnenland.atlassian.net/browse/GN-4406?atlOrigin=eyJpIjoiY2E4MGNiZjk3NDIxNDgxNjg5NjYwMzg4NTU0MTZhOWIiLCJwIjoiaiJ9

How to test/reproduce

  • Create a new regulatory statement document based on a template containing root-level articles.
  • Check if the articles are correctly parsed
  • Check if you can add root-level articles

Checks PR readiness

  • npm lint

@elpoelma elpoelma added the enhancement New feature or request label Jul 3, 2023
@elpoelma elpoelma self-assigned this Jul 3, 2023
@elpoelma elpoelma requested a review from abeforgit July 3, 2023 11:51
@abeforgit abeforgit enabled auto-merge July 5, 2023 11:30
@abeforgit abeforgit merged commit 6f9d596 into master Jul 5, 2023
@abeforgit abeforgit deleted the GN-4406-support-root-level-articles branch July 5, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants