GN-4416: add document title config (and bump editor v3.10.0 and plugins v8.4.0) #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Bumps editor and plugins
sets up correct config for document title
This makes regulations that include a document title parse correctly in GN.
also bumps
ember-resourcesto v6.1.1 to maintain compat with the pluginsconnected issues and PRs:
https://binnenland.atlassian.net/browse/GN-4416
Setup
How to test/reproduce
easiest way is to setup a document with a title in the plugin dummy app, copy the html, and use
__PM.setHtmlContent()to insert it in gnverify with PM devtools that the title node is correctly parsed as a
document_titlenode (rather than a generich4)Challenges/uncertainties
Checks PR readiness