GN-4427: fix old signatures and publications not being picked up #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There were still a few locations where we were filtering only on deleted = false, but this also filtered out all existing signatures/publishedResources,
because in sparql, deleted=false implies that the triple exists in the first place.
connected issues and PRs:
https://binnenland.atlassian.net/browse/GN-4427
Setup
How to test/reproduce
bit difficult as you need signatures that doesn't have the deleted triple. The best way is to
get a prod backup and test with known published (as per publicatie) documents.
Challenges/uncertainties
Checks PR readiness