Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4266: Reference published decisions #579

Merged
merged 3 commits into from
Sep 19, 2023
Merged

GN-4266: Reference published decisions #579

merged 3 commits into from
Sep 19, 2023

Conversation

dkozickis
Copy link
Contributor

Overview

Bumps "plugins" to enable published decisions insert

CleanShot 2023-09-19 at 12 27 30@2x

Connected issues and PRs:

https://binnenland.atlassian.net/browse/GN-4266

Setup

  1. Checkout
  2. ember s --proxy https://dev.gelinkt-notuleren.lblod.info

How to test/reproduce

Check whether it is possible to insert reference for a "Besluit". decisionsEndpoint might have to be changed to https://publicatie.gelinkt-notuleren.lblod.info/sparql as the production does not have /sparql yet.

Challenges/uncertainties

Production does not have /sparql yet

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@dkozickis dkozickis changed the title Gn 4266 GN-4266: Reference published decisions Sep 19, 2023
Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run this? I'm getting a 500 for the POST requests to the dev endpoint
could be the endpoint needs updating
EDIT: I was proxying to localhost, trying dev GN as per instructions now
EDIT2: yeah no still broken

@dkozickis
Copy link
Contributor Author

Did you run this? I'm getting a 500 for the POST requests to the dev endpoint could be the endpoint needs updating EDIT: I was proxying to localhost, trying dev GN as per instructions now EDIT2: yeah no still broken

I have tested with https://publicatie.gelinkt-notuleren.lblod.info/sparql, that one works.

https://publicatie.dev.gelinkt-notuleren.lblod.info/sparql is just broken by itself it seems

CleanShot 2023-09-19 at 16 46 46@2x

@abeforgit
Copy link
Member

abeforgit commented Sep 19, 2023

well, yeah 😬 can you fix it?
it's likely just a pull and redeploy of the dev env

@abeforgit
Copy link
Member

I've fixed it

@abeforgit abeforgit merged commit bbd6251 into master Sep 19, 2023
@abeforgit abeforgit deleted the GN-4266 branch September 19, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants