GN-4528: Fix issues reported by dependency-lint
#581
Merged
+289
−737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
GN-4528: Fix issues reported by
dependency-lint
dependency-lint
dependency-lint
CI job to passMost of the issues reported were fixed by reducing the major version that was bumped by dependabot.
The trickiest one was forcing
@appuniversum/ember-appuniversum
to resolvetracked-toolbox
to^2.0.0
. Turns out you need to useoverrides
field fornpm
notresolutions
likeyarn
does 😵💫Using overrides is the expected approach from appuniversum team - appuniversum/ember-appuniversum#421 (comment)
Connected issues and PRs:
https://binnenland.atlassian.net/browse/GN-4528
Setup
npm i
ember dependency-lint
How to test/reproduce
ember dependency-lint
should passChecks PR readiness