Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4528: Fix issues reported by dependency-lint #581

Merged
merged 1 commit into from
Sep 28, 2023
Merged

GN-4528: Fix issues reported by dependency-lint #581

merged 1 commit into from
Sep 28, 2023

Conversation

dkozickis
Copy link
Contributor

@dkozickis dkozickis commented Sep 27, 2023

Overview

GN-4528: Fix issues reported by dependency-lint

  • fix issues reported by dependency-lint
  • require dependency-lint CI job to pass

Most of the issues reported were fixed by reducing the major version that was bumped by dependabot.

The trickiest one was forcing @appuniversum/ember-appuniversum to resolve tracked-toolbox to ^2.0.0. Turns out you need to use overrides field for npm not resolutions like yarn does 😵‍💫
Using overrides is the expected approach from appuniversum team - appuniversum/ember-appuniversum#421 (comment)

Connected issues and PRs:

https://binnenland.atlassian.net/browse/GN-4528

Setup

  1. Checkout
  2. npm i
  3. ember dependency-lint

How to test/reproduce

ember dependency-lint should pass

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@dkozickis
Copy link
Contributor Author

dependency-lint job passing here - https://build.redpencil.io/repos/2356/pipeline/347/11

@elpoelma elpoelma merged commit fc625a1 into master Sep 28, 2023
@elpoelma elpoelma deleted the GN-4528 branch September 28, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants