Add say-content styling to all treatment content (Fixes sub/superscript) #585
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some preview content in GN did not show the same as content on other places. The problem comes from a missing class
say-content
.This adds the same styling of
say-content
toc-template-content--treatment
, which contains this content where the styling was missing.connected issues and PRs:
https://binnenland.atlassian.net/browse/GN-4210
lblod/ember-rdfa-editor#989
Setup
npm link the editor
npm link @lblod/ember-rdfa-editor
in this repoHow to test/reproduce
See ticket for a specific example. The easiest is to add some superscript/subscript to an agenda item and see that this is rendered correctly on any place an agenda item is rendered.
Challenges/uncertainties
I wanted to avoid this solution as it is a bit hacky (and needs an editor change)
However:
c-template-content--treatment
is enough as a class to identify the treatment part in the template. No need to add another class.say-content
in the frontend somehow.say-content
via queries in components, but there are many components showing this preview.say-content
class via queries in a special getter for treatment (e.g.previewContent
). But this means parsing the html before it is rendered. This might be better, but for big documents this could take some time and the css fix is quite easy to understand.