GN-4529: ensure editor is only initialized after prefix attribute of wrapping div has been set #591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR ensures that the editor component is only initialized after the prefix attribute of it's wrapping container has been set.
This PR:
setUpPrefixAttr
modifier on the wrapping container which sets the prefix attribute. It also controls theready
property which indicates when the editor may be initialized.prefix
attribute has been set, theready
property is set totrue
setUpPrefixAttr
modifier is destroyed, theready
property is set tofalse
(as the prefix attribute no longer exists)=> this also means that the
setUpPrefixAttr
modifier is not generic and is only meant to be used in combination with the wrapping container.This PR should solve the issue with the datastore calculation after having saved a document. (When the datastore is calculated, the
prefix
attribute should be set)connected issues and PRs:
Should solve GN-4529
How to test/reproduce
Challenges/uncertainties
prefix
attribute directly in a template (see [Bug] can not dynamically assign prefix attribute in templates emberjs/ember.js#19369)setUpPrefixAttr
is not generic and should only be used once (as it controls the component propertyready
). I could not find a better way to solve this.Checks PR readiness