GN-4599: prevent confirmation dialog from popping up twice. #607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR solves an issue with the confirmation dialog popping up twice upon leaving an edit route.
Specifically, it updates the
isLoadingRoute
to more correctly check if aRouteInfo
object represents aloading
route.The
isLoadingRoute
function now checks for the following possible syntaxes:loading
${routename}-loading
${routename}_loading
(new)connected issues and PRs:
GN-4599
How to test/reproduce
Challenges/uncertainties
The
isLoadingRoute
function is quite volatile. If something changes to the internal naming of ember loading routes, the function would need to be updated.Another possibility is to remove the
routeWillChange
listener after the user has pressedok
in the confirmation dialog.Checks PR readiness