Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4617: disable space-invisible #610

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Dec 4, 2023

Overview

This PR disables the space invisible in this application as it causes large slowdowns when pasting large documents/typing in large documents.

The other formatting marks (pilcrow and carriage return) do not cause a large slowdown as they are way more sparse.

connected issues and PRs:

GN-4617
lblod/ember-rdfa-editor#1057

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@dkozickis dkozickis merged commit 5db2cb0 into master Dec 14, 2023
@dkozickis dkozickis deleted the GN-4617-disable-space-invisible branch December 14, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants