Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation for 'insert' in the sidebar #615

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

piemonkey
Copy link
Contributor

Overview

In the sidebar, this used to say 'Insert':
image

connected issues and PRs:

https://binnenland.atlassian.net/browse/GN-4665

Setup

Recommended, some way to change locales easily, e.g. this extension

How to test/reproduce

Open any agendapoint or regulatory statement and confirm that the word 'insert' is in the correct language (NL for anything but locale of en-US).

Challenges/uncertainties

I don't know the correct dutch and there seems to be difference with the insert-label translation.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma merged commit 035d6f0 into master Jan 5, 2024
3 checks passed
@elpoelma elpoelma deleted the fix/translate-insert branch January 5, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants