Improve browser language detection and set nl-be fallback #621
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piemonkey
reviewed
Feb 8, 2024
| @@ -1,6 +1,7 @@ | |||
| import Route from '@ember/routing/route'; | |||
| import { service } from '@ember/service'; | |||
| import ENV from 'frontend-gelinkt-notuleren/config/environment'; | |||
| import { decentLocaleMatch } from '../utils/intl'; | |||
There was a problem hiding this comment.
My intent was that we would import the function from the editor repo rather than having to duplicate it in every codebase. Is there a good reason not to do that?
There was a problem hiding this comment.
Yeah I see, the main reason I did not import it from the editor is that the function is not really inherent to the editor codebase (it is quite generic).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR applies the same set of changes as lblod/ember-rdfa-editor#1117, improving the detection of the user's browser language.
connected issues and PRs:
lblod/ember-rdfa-editor#1117
How to test/reproduce
Use a locale switcher to try different combinations of locales and that it always translates the UI as expected. In that add-on you can select multiple locales by clicking the switch at the top:
Checks PR readiness