Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch content from file if not present on the versioned-notulen #626

Merged
merged 4 commits into from
Mar 21, 2024
Merged

fetch content from file if not present on the versioned-notulen #626

merged 4 commits into from
Mar 21, 2024

Conversation

nvdk
Copy link
Member

@nvdk nvdk commented Feb 7, 2024

Overview

connected issues and PRs:

Setup

How to test/reproduce

Challenges/uncertainties

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@abeforgit abeforgit marked this pull request as ready for review March 20, 2024 20:34
@abeforgit abeforgit enabled auto-merge March 20, 2024 20:38
@abeforgit abeforgit merged commit 292c567 into master Mar 21, 2024
3 checks passed
@abeforgit abeforgit deleted the feature/notulen-content-as-file branch March 21, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvdk @abeforgit