Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null-checks to behandeling-van-agendapunt component (hotfix) #628

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Mar 4, 2024

Overview

This PR adds several null/undefined checks to the behandeling-van-agendapunt component in order to prevent undefined errors.

connected issues and PRs:

None

How to test/reproduce

  • Start the application
  • Open up a meeting with agendapoints
  • Remove an agendapoint
  • The container is undefined error should no longer show up

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma added the bug Something isn't working label Mar 4, 2024
@elpoelma elpoelma requested review from dkozickis and abeforgit March 4, 2024 12:19
@elpoelma elpoelma changed the title Add null-checks to behandeling-van-agendapunt component Add null-checks to behandeling-van-agendapunt component (hotfix) Mar 4, 2024
@elpoelma elpoelma merged commit 54fb3a2 into v5.9.x Mar 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants