Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop requirement to pass template to its own loadBody method #634

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Drop requirement to pass template to its own loadBody method #634

merged 3 commits into from
Apr 11, 2024

Conversation

elpoelma
Copy link
Contributor

Overview

This small PR does two things:

  • rename loadTemplateBody method on regulatory statement templates to loadBody for clarity
  • remove the requirement to pass template object to itself in the loadBody method, as it is unnecessary and quite confusing.

How to test/reproduce

  • Open up the app
  • Create a new regulatory statement
  • Ensure the template is correctly loaded

@elpoelma elpoelma requested review from dkozickis and piemonkey March 28, 2024 11:17
@elpoelma elpoelma force-pushed the internal/improve-template-load-body-method branch from c3927bd to ab41287 Compare March 28, 2024 11:17
@abeforgit abeforgit enabled auto-merge April 11, 2024 08:46
@abeforgit abeforgit merged commit 6e6f189 into master Apr 11, 2024
3 checks passed
@abeforgit abeforgit deleted the internal/improve-template-load-body-method branch April 11, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkozickis dkozickis Awaiting requested review from dkozickis

@piemonkey piemonkey Awaiting requested review from piemonkey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elpoelma @abeforgit