Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update editor to 9.6.1 #636

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Update editor to 9.6.1 #636

merged 3 commits into from
Apr 11, 2024

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Apr 1, 2024

Overview

This PR updates the editor to version 9.6.1.
This should not be a breaking release.

Note: This should probably be reviewed by someone else than me as I took this over while @elpoelma is away. - @piemonkey

connected issues and PRs:

lblod/frontend-reglementaire-bijlage#230

How to test/reproduce

  • Open up the application
  • Ensure that the different editor instances throughout the application still work as expected

Challenges/uncertainties

Note: this update does not yet remove usage of API deprecations introduced in 9.6.0.
This PR is specifically made to ensure that the 9.6.0 works as expected and does not include any unexpected breaking changes.
This PR also does not include any new features.
Once version 9.6.0 has been released, this PR can be updated.

Note: the CI (specifically the install step) will fail for this PR, as the plugins package does not officially support version 9.6.0-next.0 (it only supports the ^9.0.0 range).

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma changed the title Update editor to 9.6.0-next.0 Update editor to 9.6.0-next.0 Apr 1, 2024
@piemonkey piemonkey changed the title Update editor to 9.6.0-next.0 Update editor to 9.6.0 Apr 9, 2024
@piemonkey piemonkey marked this pull request as ready for review April 9, 2024 15:05
Copy link
Contributor

@dkozickis dkozickis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I please ask to wait for lblod/ember-rdfa-editor#1186 and 9.6.1 version of editor 👀

@abeforgit abeforgit changed the title Update editor to 9.6.0 Update editor to 9.6.1 Apr 11, 2024
@piemonkey piemonkey merged commit 9836a59 into master Apr 11, 2024
3 checks passed
@piemonkey piemonkey deleted the internal/update-editor branch April 11, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants