Add support for signed/published-resource contents in files #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
elpoelma
reviewed
Apr 15, 2024
elpoelma
reviewed
Apr 15, 2024
Setting 'body' on a versioned-notulen doesn't have any meaning, and presumably is a relic of an older model. behandelingen-list had a controller that was supplying a value used elsewhere in the parent, so I made it an argument.
abeforgit
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Handle the possibility that published or signed resources have content in a file instead of directly in the resource as a string. Also added some very basic error handling for file lookups instead of just returning blank data.
connected issues and PRs:
Part of #639
Needed for lblod/app-gelinkt-notuleren#181
Setup
Needs to be tested with the app-gn from the PR.
How to test/reproduce
See the app-gn PR on how to test/reproduce.
Challenges/uncertainties
The sheer number of deprecations makes it hard to see messages...
Checks PR readiness